fix ansible linter errors

defaults/main.yml

@@ -1,3 +1,21 @@
 accounts:
   users: {}
   groups: {}
+
+defaultgroup:
+  system: true
+  state: present
+  gid: "{{ omit }}"
+
+defaultuser:
+  genssh: false
+  ssh_key_type: ed25519
+  group: ~
+  groups: []
+  system: true
+  home: ~
+  state: present
+  uid: "{{ omit }}"
+  password: "*"
+  shell: "/usr/sbin/nologin"
+  authorized_keys: {}

tasks/groups.yml

@@ -1,11 +1,6 @@
-- set_fact:
+- name: apply overrides to current group
-    defaultgroup:
+  set_fact:
-      system: true
+    group: "{{ {}|combine(defaultgroup, currentgroup.value|d({}), {'name': currentgroup.key} ) }}"
-      state: present
-      gid: "{{ omit }}"
-
-- set_fact:
-    group: "{{ defaultgroup|combine(currentgroup.value|d({}), {'name': currentgroup.key} ) }}"
 
 - name: create groups
   group:

tasks/users.yml

@@ -1,19 +1,11 @@
-- set_fact:
+- name: store dynamic defaults
-    defaultuser:
+  set_fact:
-      genssh: false
+    dynamic_defaultuser:
-      ssh_key_type: ed25519
+      userhome: "{{ ('/var/lib/'+currentuser.key) if (currentuser.value.system|d(True)) else ('/home/'+currentuser.key) }}"
-      group: ~
-      groups: []
-      home: "{{ ('/var/lib/'+currentuser.key) if (currentuser.value.system|d(True)) else ('/home/'+currentuser.key) }}"
-      system: true
-      state: present
-      uid: "{{ omit }}"
-      password: "*"
-      shell: "/usr/sbin/nologin"
-      authorized_keys: {}
 
-- set_fact:
+- name: apply overrides to current user
-    user: "{{ defaultuser|combine(currentuser.value|d({}), {'name': currentuser.key} ) }}"
+  set_fact:
+    user: "{{ {}|combine(defaultuser, dynamic_defaultuser, currentuser.value|d({}), {'name': currentuser.key} ) }}"
 
 - name: "create user ({{ user.name }})"
   user: