From 2c64104b6061002c40ef179b0ecabb13cd718d1f Mon Sep 17 00:00:00 2001 From: nd Date: Tue, 9 Mar 2021 00:17:26 +0100 Subject: [PATCH] simplified mailman_list module --- library/mailman_list.py | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/library/mailman_list.py b/library/mailman_list.py index d8e72a2..3ffb753 100644 --- a/library/mailman_list.py +++ b/library/mailman_list.py @@ -44,23 +44,21 @@ def run_module(): domain = client.get_domain(addr_domain) ml = domain.create_list(addr_local) - ml_settings = ml.settings if result['changed']: result['diff']['before'] = None else: - result['diff']['before'] = dict(ml_settings) + result['diff']['before'] = dict(ml.settings) for i in module.params['settings']: - if ml_settings[i] != module.params['settings'][i]: + if ml.settings[i] != module.params['settings'][i]: result['changed'] = True - ml_settings[i] = module.params['settings'][i] + ml.settings[i] = module.params['settings'][i] - if module.check_mode: - result['diff']['after'] = dict(ml.settings) - result['diff']['after'].update(module.params['settings']) - else: - ml_settings.save() - result['diff']['after'] = dict(ml.settings) + if not module.check_mode: + ml.settings.save() + + result['diff']['after'] = dict(ml.settings) + result['diff']['after'].update(module.params['settings']) module.exit_json(**result)